Change in vdsm[master]: Make _addNetwork and _delNetwork private

danken at redhat.com danken at redhat.com
Tue Dec 9 13:58:59 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Make _addNetwork and _delNetwork private
......................................................................


Patch Set 6: Verified+1

verified on el6:

NetworkTest
    testAddDelBondedNetwork(kwargs=False)                       OK
    testAddDelBondedNetwork(kwargs=True)                        OK
    testAddDelNetwork(kwargs=False)                             OK
    testAddDelNetwork(kwargs=True)                              OK
    testAddNetworkBondWithManyVlans(kwargs=False)               OK
    testAddNetworkBondWithManyVlans(kwargs=True)                OK
    testAddNetworkManyVlans(kwargs=False)                       OK
    testAddNetworkManyVlans(kwargs=True)                        OK
    testAddNetworkVlan(kwargs=False)                            OK
    testAddNetworkVlan(kwargs=True)                             OK
    testAddNetworkVlanBond(kwargs=False)                        OK
    testAddNetworkVlanBond(kwargs=True)                         OK
    testAddVlanedBridgeless                                     OK
    testAddVlanedBridgeless_oneCommand                          OK
    testAfterNetworkSetupHook                                   OK
    testBeforeNetworkSetupHook                                  OK
    testBondHwAddress(kwargs=False)                             OK
    testBondHwAddress(kwargs=True)                              OK
    testBrokenBridgelessNetReplacement                          OK
    testDelNetworkBondAccumulation                              OK
    testDelNetworkWithMTU(kwargs=False)                         OK
    testDelNetworkWithMTU(kwargs=True)                          OK
    testDelWithoutAdd(kwargs=False)                             OK
    testDelWithoutAdd(kwargs=True)                              OK
    testDhclientLeases(kwargs='default')                        OK
    testDhclientLeases(kwargs='local')                          OK
    testEditWithoutAdd(kwargs=False)                            OK
    testEditWithoutAdd(kwargs=True)                             OK
    testFailWithInvalidBondingName(kwargs=False)                OK
    testFailWithInvalidBondingName(kwargs=True)                 OK
    testFailWithInvalidBridgeName                               OK
    testFailWithInvalidIpConfig                                 OK
    testFailWithInvalidNic(kwargs=False)                        OK
    testFailWithInvalidNic(kwargs=True)                         OK
    testFailWithInvalidParams(kwargs=False)                     OK
    testFailWithInvalidParams(kwargs=True)                      OK
    testGetRouteDeviceTo                                        OK
    testHonorBlockingDhcp                                       SKIP: Slow tests are disabled
    testIPv6ConfigNetwork                                       OK
    testIpLinkWrapper                                           OK
    testLegacyBonds                                             OK
    testLowerMtuDoesNotOverride                                 OK
    testNoBridgeLeftovers                                       OK
    testReconfigureBrNetWithVanishedPort                        OK
    testRedefineBondedNetworkIPs                                OK
    testReorderBondingOptions(kwargs=False)                     OK
    testReorderBondingOptions(kwargs=True)                      OK
    testSafeNetworkConfig(kwargs=False)                         OK
    testSafeNetworkConfig(kwargs=True)                          OK
    testSetupNetworkOutboundQos(kwargs=False)                   OK
    testSetupNetworkOutboundQos(kwargs=True)                    OK
    testSetupNetworksActiveSlave                                OK
    testSetupNetworksAddBadParams(bridged=False)                OK
    testSetupNetworksAddBadParams(bridged=True)                 OK
    testSetupNetworksAddBondWithManyVlans(kwargs=False)         OK
    testSetupNetworksAddBondWithManyVlans(kwargs=True)          OK
    testSetupNetworksAddDelBondedNetwork(kwargs=False)          OK
    testSetupNetworksAddDelBondedNetwork(kwargs=True)           OK
    testSetupNetworksAddDelDhcp(kwargs=False)                   OK
    testSetupNetworksAddDelDhcp(kwargs=True)                    OK
    testSetupNetworksAddManyVlans(kwargs=False)                 OK
    testSetupNetworksAddManyVlans(kwargs=True)                  OK
    testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=False)OK
    testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=True)OK
    testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=False)OK
    testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True)OK
    testSetupNetworksAddOverExistingBond(kwargs=False)          OK
    testSetupNetworksAddOverExistingBond(kwargs=True)           OK
    testSetupNetworksAddVlan(kwargs=False)                      OK
    testSetupNetworksAddVlan(kwargs=True)                       OK
    testSetupNetworksConnectivityCheck                          OK
    testSetupNetworksConvertVlanNetBridgeness                   OK
    testSetupNetworksDelOneOfBondNets                           OK
    testSetupNetworksEmergencyDevicesCleanupBondOverwrite(kwargs=False)SKIP: Slow tests are disabled
    testSetupNetworksEmergencyDevicesCleanupBondOverwrite(kwargs=True)SKIP: Slow tests are disabled
    testSetupNetworksEmergencyDevicesCleanupVlanOverwrite(kwargs=False)SKIP: Slow tests are disabled
    testSetupNetworksEmergencyDevicesCleanupVlanOverwrite(kwargs=True)SKIP: Slow tests are disabled
    testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=False)OK
    testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=True)OK
    testSetupNetworksMtus(kwargs=False)                         OK
    testSetupNetworksMtus(kwargs=True)                          OK
    testSetupNetworksMultiMTUsOverBond(kwargs=False)            OK
    testSetupNetworksMultiMTUsOverBond(kwargs=True)             OK
    testSetupNetworksMultiMTUsOverNic(kwargs=False)             OK
    testSetupNetworksMultiMTUsOverNic(kwargs=True)              OK
    testSetupNetworksNetCompatibilityMultipleNetsSameNic(kwargs=False)OK
    testSetupNetworksNetCompatibilityMultipleNetsSameNic(kwargs=True)OK
    testSetupNetworksNicless                                    OK
    testSetupNetworksNiclessBridgeless                          OK
    testSetupNetworksOverDhcpIface                              OK
    testSetupNetworksOverExistingBridge                         OK
    testSetupNetworksResizeBond(kwargs=False)                   OK
    testSetupNetworksResizeBond(kwargs=True)                    OK
    testSetupNetworksStableBond(kwargs=False)                   OK
    testSetupNetworksStableBond(kwargs=True)                    OK
    testStaticSourceRouting(kwargs=False)                       OK
    testStaticSourceRouting(kwargs=True)                        OK
    testTwiceAdd(kwargs=False)                                  OK
    testTwiceAdd(kwargs=True)                                   OK
    testVolatileConfig(kwargs=False)                            OK
    testVolatileConfig(kwargs=True)                             OK

----------------------------------------------------------------------
Ran 101 tests in 627.027s

OK (SKIP=5)

-- 
To view, visit http://gerrit.ovirt.org/35311
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie043a26c795a8c8d71a6142d4df45f6584120338
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list