Change in vdsm[master]: Make _addNetwork and _delNetwork private

danken at redhat.com danken at redhat.com
Tue Dec 9 13:34:27 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Make _addNetwork and _delNetwork private
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/35311/5/vdsm/network/api.py
File vdsm/network/api.py:

Line 210:         isolatedCommand = attrs.get('configurator') is None
Line 211:         # Detect if we are running an isolated command, i.e., a command that is
Line 212:         # not called as part of composed API operation like setupNetworks or
Line 213:         # editNetwork, but rather as its own API verb. This is necessary in
Line 214:         # order to maintain behavior of the _addNetwork and _delNetwork API
actually, the API verbs did not change their name.
Line 215:         # verbs
Line 216:         if isolatedCommand:
Line 217:             attrs['configurator'] = configurator = ConfiguratorClass()
Line 218:             configurator.begin()


-- 
To view, visit http://gerrit.ovirt.org/35311
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie043a26c795a8c8d71a6142d4df45f6584120338
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list