Change in vdsm[master]: jsonrpc: VM_getStats

danken at redhat.com danken at redhat.com
Tue Dec 9 11:59:03 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: VM_getStats
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/35551/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 6695: # Get statistics about a running virtual machine.
Line 6696: #
Line 6697: # @vmID:     The UUID of the VM
Line 6698: #
Line 6699: # @runHooks: if True it will run before_get_vm_stats
This was never intended to be exposed in the schema - it is an implementation detail of getAllVmStats. It can be hidden in an internal helper function.
Line 6700: #            and after_get_vm_stats hooks
Line 6701: #
Line 6702: # Returns:
Line 6703: # An array containing a single VmStats record


-- 
To view, visit http://gerrit.ovirt.org/35551
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0657482b59ee0b3e943afda652e94906fe24739
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list