Change in vdsm[master]: virt: drop useless return value of VM.create

fromani at redhat.com fromani at redhat.com
Mon Dec 8 14:34:34 UTC 2014


Francesco Romani has uploaded a new change for review.

Change subject: virt: drop useless return value of VM.create
......................................................................

virt: drop useless return value of VM.create

It is pointless to return the Vm configuration,
or even just status, from the Vm.create verb.

Being the actual Vm creation asynchronous,
the return value provides no value besides
the success/failure.

Moreover:
* Engine was anyway ignoring this data
* Engine needs update (either poll or future
  push event) anyway to get meaningful information.

Change-Id: I8689de514379285cb91cebc84be6ec5df5c9875b
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/clientIF.py
M vdsm/rpc/vdsmapi-schema.json
2 files changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/34871/1

diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 1f54700..77ea5d0 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -392,7 +392,7 @@
         vm.run()
         self.log.debug("Total desktops after creation of %s is %d" %
                        (vmParams['vmId'], container_len))
-        return {'status': doneCode, 'vmList': vm.getConf()}
+        return {'status': doneCode}
 
     @utils.traceback()
     def _recoverThread(self):
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 624b686..238692d 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -6042,14 +6042,10 @@
 #
 # @vmParams:  The VM definition
 #
-# Returns:
-# The VM definition, as created
-#
 # Since: 4.10.0
 ##
 {'command': {'class': 'VM', 'name': 'create'},
- 'data': {'vmID': 'UUID', 'vmParams': 'VmParameters'},
- 'returns': 'VmDefinition'}
+ 'data': {'vmID': 'UUID', 'vmParams': 'VmParameters'}}
 
 ##
 # @VM.desktopLock:


-- 
To view, visit http://gerrit.ovirt.org/34871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8689de514379285cb91cebc84be6ec5df5c9875b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list