Change in vdsm[master]: remove needless parameter

ibarkan at redhat.com ibarkan at redhat.com
Sun Dec 7 10:57:01 UTC 2014


Ido Barkan has uploaded a new change for review.

Change subject: remove needless parameter
......................................................................

remove needless parameter

Change-Id: I1dd97c1a64ef3dd9deb96e65ed5ee9f31d26a443
Signed-off-by: ibarkan <ibarkan at redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/35913/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 37597fd..11b49db 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -883,18 +883,18 @@
     def testSetupNetworksConvertVlanNetBridgeness(self):
         "Convert a bridged networks to a bridgeless one and viceversa"
 
-        def setupNetworkBridged(nic, bridged):
-            networks = {NETWORK_NAME: dict(vlan=VLAN_ID,
-                                           nic=nic, bridged=bridged)}
+        def setupNetworkBridged(bridged):
+            networks = {NETWORK_NAME: dict(vlan=VLAN_ID, nic=nics[0],
+                                           bridged=bridged)}
             status, msg = self.vdsm_net.setupNetworks(networks, {},
                                                       NOCHK)
             self.assertEqual(status, SUCCESS, msg)
             self.assertNetworkExists(NETWORK_NAME, bridged)
 
         with dummyIf(1) as nics:
-            setupNetworkBridged(nics[0], True)
-            setupNetworkBridged(nics[0], False)
-            setupNetworkBridged(nics[0], True)
+            setupNetworkBridged(True)
+            setupNetworkBridged(False)
+            setupNetworkBridged(True)
 
             status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME:
                                                        dict(remove=True)},


-- 
To view, visit http://gerrit.ovirt.org/35913
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1dd97c1a64ef3dd9deb96e65ed5ee9f31d26a443
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>


More information about the vdsm-patches mailing list