Change in vdsm[master]: net tests: allowDhcp is no-op if there is no firewall

danken at redhat.com danken at redhat.com
Sat Dec 6 21:31:03 UTC 2014


Dan Kenigsberg has uploaded a new change for review.

Change subject: net tests: allowDhcp is no-op if there is no firewall
......................................................................

net tests: allowDhcp is no-op if there is no firewall

firewall.allowDhcp is intended to allow DHCP traffic to the tested
interface. With this patch, we assume that if we find no firewall
service running, DHCP is already allowed.

This change allows DHCP-related tests to run when no firewall is
running on host.

Change-Id: I7de84c081ab49cca3a7f358cdffd25a21c08ea7b
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/firewall.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/35911/1

diff --git a/tests/functional/firewall.py b/tests/functional/firewall.py
index ee7bb9f..7b7d616 100644
--- a/tests/functional/firewall.py
+++ b/tests/functional/firewall.py
@@ -48,7 +48,7 @@
             _execCmdChecker([_FIREWALLD_BINARY.cmd, '--zone=trusted',
                             '--change-interface=' + veth])
         else:
-            raise SkipTest('No firewall service detected.')
+            logging.info('No firewall service detected.')
     except FirewallError as e:
         raise SkipTest('Failed to allow dhcp traffic in firewall because of '
                        '%s' % e)
@@ -73,7 +73,7 @@
         _execCmdChecker([_FIREWALLD_BINARY.cmd, '--zone=trusted',
                         '--remove-interface=' + veth])
     else:
-        logging.error('The firewall service is gone.')
+        logging.warning('No firewall service detected.')
 
 
 def _serviceRunning(name):


-- 
To view, visit http://gerrit.ovirt.org/35911
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7de84c081ab49cca3a7f358cdffd25a21c08ea7b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list