Change in vdsm[master]: networkTests: Extend a test to also consider DHCPv6

danken at redhat.com danken at redhat.com
Sat Dec 6 08:21:46 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: networkTests: Extend a test to also consider DHCPv6
......................................................................


Patch Set 37:

(2 comments)

http://gerrit.ovirt.org/#/c/30532/37/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 422:     def assertMtu(self, mtu, *elems):
Line 423:         for elem in elems:
Line 424:             self.assertEquals(int(mtu), int(self.vdsm_net.getMtu(elem)))
Line 425: 
Line 426:     def assertAddrInRange(self, addrs, addr_to_int=_ipv4_to_int,
> And then resolve the conversion function, right?
Yes
Line 427:                           range_from=DHCP_RANGE_FROM, range_to=DHCP_RANGE_TO):
Line 428:         passes = (addr_to_int(range_from) <= addr_to_int(addr) <=
Line 429:                   addr_to_int(range_to) for addr in addrs)
Line 430:         self.assertTrue(any(passes), 'no address {0} in expected range'.format(


Line 427:                           range_from=DHCP_RANGE_FROM, range_to=DHCP_RANGE_TO):
Line 428:         passes = (addr_to_int(range_from) <= addr_to_int(addr) <=
Line 429:                   addr_to_int(range_to) for addr in addrs)
Line 430:         self.assertTrue(any(passes), 'no address {0} in expected range'.format(
Line 431:             addrs))
> We obtain (up to, if successful) one address. There can be others: link-loc
Ok
Line 432: 
Line 433:     def testLegacyBonds(self):
Line 434:         if not (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL)
Line 435:                 and caps.osversion()['version'].startswith('6')):


-- 
To view, visit http://gerrit.ovirt.org/30532
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5d821edd54681a7a8c1013a90af61ae835baa39
Gerrit-PatchSet: 37
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list