Change in vdsm[master]: hooks: Remove sudo use from ethtool_options hooks

danken at redhat.com danken at redhat.com
Wed Dec 3 14:42:44 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: hooks: Remove sudo use from ethtool_options hooks
......................................................................


hooks: Remove sudo use from ethtool_options hooks

This hook is running from supevdsm context therefore runs as root.

Change-Id: I3f1529452050370c82eb2a2675b74c2e5136d427
Signed-off-by: Dima Kuznetsov <dkuznets at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/35725
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm_hooks/ethtool_options/Makefile.am
M vdsm_hooks/ethtool_options/ethtool_options.py
D vdsm_hooks/ethtool_options/sudoers
3 files changed, 1 insertion(+), 10 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35725
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f1529452050370c82eb2a2675b74c2e5136d427
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list