Change in vdsm[master]: multipath: use backup files instead of rotateFiles

smizrahi at redhat.com smizrahi at redhat.com
Tue Dec 2 13:05:11 UTC 2014


Saggi Mizrahi has posted comments on this change.

Change subject: multipath: use backup files instead of rotateFiles
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/34077/5/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:

Line 148:             first = mpathconf[0]
Line 149:             second = mpathconf[1]
Line 150:         except IndexError:
Line 151:             pass
Line 152: 
unrelated
Line 153:         if MPATH_CONF_PRIVATE_TAG in second:
Line 154:             log.info("Manual override for multipath.conf detected - "
Line 155:                      "preserving current configuration")
Line 156:             if MPATH_CONF_TAG not in first:


Line 173:     log.debug("multipath Defaulting to False")
Line 174:     return False
Line 175: 
Line 176: 
Line 177: def setupMultipath():
Just run setup multipath through supervdsm instead of using sudo
Line 178:     """
Line 179:     Set up the multipath daemon configuration to the known and
Line 180:     supported state. The original configuration, if any, is saved
Line 181:     """


-- 
To view, visit http://gerrit.ovirt.org/34077
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96a9251ebc852fcdf39239ba50f43dd2343b83a6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list