Change in vdsm[master]: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64

vdelima at redhat.com vdelima at redhat.com
Tue Dec 2 12:21:50 UTC 2014


Vitor de Lima has posted comments on this change.

Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/33871/4/vdsm.spec.in
File vdsm.spec.in:

Line 160: Requires: libguestfs-tools-c >= 1:1.26.7-2
Line 161: %endif
Line 162: 
Line 163: %ifarch ppc64
Line 164: %define libvirt_version 1.2.2
> Does this split really help? Would el7-for-ppc ship a different libvirt ver
This way VDSM still builds on RHEL 7, otherwise we would have unnecessarily raised the required version in x86-64. Like the issue with the kernel version in the lscpu patch, I'm sure checking the package version is not a good idea because frequently those features are backported to earlier versions.
Line 165: %else
Line 166: %define libvirt_version 1.1.1
Line 167: %endif
Line 168: 


-- 
To view, visit http://gerrit.ovirt.org/33871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list