Change in vdsm[master]: External hypervisor VMs integration

shavivi at redhat.com shavivi at redhat.com
Tue Dec 2 11:50:23 UTC 2014


Shahar Havivi has posted comments on this change.

Change subject: External hypervisor VMs integration
......................................................................


Patch Set 33:

(1 comment)

http://gerrit.ovirt.org/#/c/33309/33/vdsm/v2v.py
File vdsm/v2v.py:

Line 38:         for vm in conn.listAllDomains():
Line 39:             root = ET.fromstring(vm.XMLDesc(0))
Line 40:             params = {}
Line 41:             params['vmName'] = vm.name()
Line 42:             if vm.state()[0] == libvirt.VIR_DOMAIN_SHUTOFF:
Dan,
Is it ok to log the vm with its actual status to vdsm log?
Assuming that this verb will not be called very often and the list of vms will be approximately 50 vms...
Line 43:                 params['status'] = "Down"
Line 44:             else:
Line 45:                 params['status'] = "Up"
Line 46:             try:


-- 
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list