Change in vdsm[master]: External hypervisor VMs integration

danken at redhat.com danken at redhat.com
Tue Dec 2 11:25:43 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: External hypervisor VMs integration
......................................................................


Patch Set 32:

(1 comment)

http://gerrit.ovirt.org/#/c/33309/32/vdsm/v2v.py
File vdsm/v2v.py:

Line 53:             ret.append(params)
Line 54:         return ret
Line 55: 
Line 56: 
Line 57: def _memToMb(size, unit):
yes, this function converts to MiB, so it should be named

_mem_to_MiB

or something like that
Line 58:     lunit = unit.lower()
Line 59:     if lunit in ('bytes', 'b'):
Line 60:         return size / 1024 / 1024
Line 61:     elif lunit in ('kib', 'k'):


-- 
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list