Change in vdsm[master]: External hypervisor VMs integration

danken at redhat.com danken at redhat.com
Mon Dec 1 21:55:56 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: External hypervisor VMs integration
......................................................................


Patch Set 30:

(1 comment)

http://gerrit.ovirt.org/#/c/33309/30/vdsm/virt/vmstatus.py
File vdsm/virt/vmstatus.py:

Line 25: DOWN = 'Down'
Line 26: MIGRATION_DESTINATION = 'Migration Destination'
Line 27: MIGRATION_SOURCE = 'Migration Source'
Line 28: PAUSED = 'Paused'
Line 29: POWERING_DOWN = 'Powering down'
> That was my first solution, but I got some comments here:
But why do we need any mapping at all? can't v2v return the libvirt numerical statuses?
Line 30: POWERING_UP = 'Powering up'
Line 31: POWER_MANAGEMENT_SUSPENDED = 'PMSuspended'
Line 32: REBOOT_IN_PROGRESS = 'RebootInProgress'
Line 33: RESTORING_STATE = 'Restoring state'


-- 
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list