Change in vdsm[master]: Fixed %post script error during upgrade

danken at redhat.com danken at redhat.com
Mon Dec 1 10:18:08 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Fixed %post script error during upgrade
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/35739/1/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:

Line 255:         # of added bonding options or tweaked kernel defaults) it has to be run
Line 256:         # after load_needed_modules (modprobe bonding).
Line 257:         # NetworkManager must not crash on nmcli conn delete.
Line 258:         run_tasks " \
Line 259:             set_sasl_password \
why should we run this on every vdsm startup?
calling it from within `vdsm-tool configure` makes more sense to me.
Line 260:             mkdirs \
Line 261:             configure_coredump \
Line 262:             configure_vdsm_logs \
Line 263:             run_init_hooks \


-- 
To view, visit http://gerrit.ovirt.org/35739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7808f4f217ba3d6d30a60fab6233e36a29f0098
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list