Change in vdsm[master]: tests: sampling: add initial HostStatsThread tests

fromani at redhat.com fromani at redhat.com
Mon Dec 1 08:47:21 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: tests: sampling: add initial HostStatsThread tests
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/29566/3/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 481:     """
Line 482:     A thread that periodically samples host statistics.
Line 483:     """
Line 484:     AVERAGING_WINDOW = 5
Line 485:     SAMPLE_INTERVAL_SEC = 2
> can we monkey-patch the class member, instead of adding a test-only arg?
Good point. Done.
Line 486:     _CONNLOG = logging.getLogger('connectivity')
Line 487: 
Line 488:     def __init__(self, log, sampleInterval=None):
Line 489:         self.startTime = time.time()


-- 
To view, visit http://gerrit.ovirt.org/29566
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4e5765364cf46e1ebfaac72aa5f75c80e83779e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list