Change in vdsm[ovirt-3.5]: tool: Fix TypeError when configuration check fails

ybronhei at redhat.com ybronhei at redhat.com
Sun Aug 31 21:25:01 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: tool: Fix TypeError when configuration check fails
......................................................................


tool: Fix TypeError when configuration check fails

When is-configured and validate-config failed for some modules, we got a
TypeError trying to join a list of configurator objects, instead of list
of strings.

    TypeError: sequence item 0: expected string, Sanlock found

Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127877
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31782
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: mooli tayer <mtayer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32061
Tested-by: mooli tayer <mtayer at redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  mooli tayer: Verified



-- 
To view, visit http://gerrit.ovirt.org/32061
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>


More information about the vdsm-patches mailing list