Change in vdsm[ovirt-3.5]: tool: Raise UsageError when used incorrectly

ybronhei at redhat.com ybronhei at redhat.com
Sun Aug 31 21:21:05 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: tool: Raise UsageError when used incorrectly
......................................................................


tool: Raise UsageError when used incorrectly

Commit e5e80540e8 added a new type of error, when user try to configure
non existing module. The test for this feature expect a SystemExit
exception, but the code was actualy raising a KeyError.

Seems that both the test and the code are wrong, so now a UsageError is
raised in this case.

Change-Id: I8e0528c84b41eee56c141d725c837cf48df5d186
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31735
Reviewed-by: mooli tayer <mtayer at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32053
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Tested-by: mooli tayer <mtayer at redhat.com>
---
M lib/vdsm/tool/configurator.py
M tests/toolTests.py
2 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  mooli tayer: Verified



-- 
To view, visit http://gerrit.ovirt.org/32053
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e0528c84b41eee56c141d725c837cf48df5d186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>


More information about the vdsm-patches mailing list