Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required

ybronhei at redhat.com ybronhei at redhat.com
Sat Aug 30 22:54:34 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Signs vdsm upgraded version for special treatment if required
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/31561/9/vdsm.spec.in
File vdsm.spec.in:

Line 718: 
Line 719: # We keep the previous rpm version number in a file for managing upgrade flow
Line 720: # in vdsmd_init_script upgraded_version_check task
Line 721: if [ "$1" -ge 1 ]; then
Line 722:     rpm -q %{vdsm_name} > "%{_localstatedir}/lib/%{vdsm_name}/upgraded_version"
> I do not like rpm information leaks out of spec file.
this is the way I found to know previous version.. any better ideas?

upgrading a->b and b->c will be fine in that case. lets say 3.2 to another 3.2 won't make any change. 3.2 to any >=3.3 will run the configure during first startup. i don't see any problem with that
Line 723: fi
Line 724: 
Line 725: %post
Line 726: %{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null


-- 
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list