Change in vdsm[master]: Live Merge: Simplify pivot flow
alitke at redhat.com
alitke at redhat.com
Fri Aug 29 13:41:03 UTC 2014
Adam Litke has posted comments on this change.
Change subject: Live Merge: Simplify pivot flow
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31849/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 5381: elif not cleanThread.isSuccessful():
Line 5382: # At this point we know the thread is not alive and the
Line 5383: # cleanup failed. Retry it with a new thread.
Line 5384: startCleanup(storedJob, drive, doPivot)
Line 5385: jobsRet[jobID] = entry
> We can simplify this a little bit:
Done
Line 5386: return jobsRet
Line 5387:
Line 5388: def merge(self, driveSpec, baseVolUUID, topVolUUID, bandwidth, jobUUID):
Line 5389: if not caps.getLiveMergeSupport():
--
To view, visit http://gerrit.ovirt.org/31849
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6a9ea7096b5d81f418754d411f135450bf572e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list