Change in vdsm[master]: el6_tests: testlib not available at el6.5

danken at redhat.com danken at redhat.com
Thu Aug 28 13:09:21 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: el6_tests: testlib not available at el6.5
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/32124/2/tests/toolTests.py
File tests/toolTests.py:

Line 87:         # make sure this is indeed a topological sort.
Line 88:         before_m = set()
Line 89:         for m in modules:
Line 90:             for n in m.getRequires():
Line 91:                 self.assertTrue(n in before_m)
I prefer the former. In case of failure, assertIn()'s message is much clearer.
Line 92:             before_m.add(m.getName())
Line 93: 
Line 94:     @monkeypatch.MonkeyPatch(
Line 95:         configurator,


-- 
To view, visit http://gerrit.ovirt.org/32124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6346d77d72febe40082e47dbc8d98dac41ed14a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list