Change in vdsm[ovirt-3.5]: el6_tests: fix toolTests to use VdsmTestCase so that assertI...

mtayer at redhat.com mtayer at redhat.com
Wed Aug 27 21:39:07 UTC 2014


Hello Yaniv Bronhaim, Antoni Segura Puimedon, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/32103

to review the following change.

Change subject: el6_tests: fix toolTests to use VdsmTestCase so that assertIn is available
......................................................................

el6_tests: fix toolTests to use VdsmTestCase so that assertIn is available

Change-Id: Ibb564320db9db1b3349c7fbb87bc63a8a044c6b2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31968
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/toolTests.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/32103/1

diff --git a/tests/toolTests.py b/tests/toolTests.py
index 53ddeba..8e20c71 100644
--- a/tests/toolTests.py
+++ b/tests/toolTests.py
@@ -28,6 +28,7 @@
 from vdsm.tool import upgrade
 from vdsm import utils
 import monkeypatch
+from testlib import VdsmTestCase
 from unittest import TestCase
 import tempfile
 import os
@@ -52,7 +53,7 @@
         return self._dependencies
 
 
-class ConfiguratorTests(TestCase):
+class ConfiguratorTests(VdsmTestCase):
 
     @monkeypatch.MonkeyPatch(
         configurator,


-- 
To view, visit http://gerrit.ovirt.org/32103
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb564320db9db1b3349c7fbb87bc63a8a044c6b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list