Change in vdsm[ovirt-3.5]: tool: Fix compatibility with Python 2.6

mtayer at redhat.com mtayer at redhat.com
Wed Aug 27 15:26:08 UTC 2014


Hello Nir Soffer, Dan Kenigsberg, Francesco Romani,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/32056

to review the following change.

Change subject: tool: Fix compatibility with Python 2.6
......................................................................

tool: Fix compatibility with Python 2.6

Commit 398d016b58 was merged too quickly, before Python developers could
add set literals to Python 2.6. Since this is quite late now to add it,
I think we should use the good old set() syntax.

Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31734
Reviewed-by: Francesco Romani <fromani at redhat.com>
Tested-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/tool/configurators/libvirt.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/32056/1

diff --git a/lib/vdsm/tool/configurators/libvirt.py b/lib/vdsm/tool/configurators/libvirt.py
index c1ee527..da19da2 100644
--- a/lib/vdsm/tool/configurators/libvirt.py
+++ b/lib/vdsm/tool/configurators/libvirt.py
@@ -112,7 +112,7 @@
             content['removeConf'](self, content['path'])
 
     def getRequires(self):
-        return {'certificates'}
+        return set(['certificates'])
 
     def _getPersistedFiles(self):
         """


-- 
To view, visit http://gerrit.ovirt.org/32056
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list