Change in vdsm[master]: iproute2, dhclient: Deal with v4/v6 protocols separately
danken at redhat.com
danken at redhat.com
Wed Aug 27 10:45:28 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: iproute2, dhclient: Deal with v4/v6 protocols separately
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/31104/4/lib/vdsm/ipwrapper.py
File lib/vdsm/ipwrapper.py:
Line 566: """
Line 567: family = ['-%s' % family] if family in (4, 6) else []
Line 568: command = [_IP_BINARY.cmd] + family + ['addr', 'flush', 'dev', dev]
Line 569: if family == 6:
Line 570: command += ['scope', 'global']
> Could you maybe put a comment of why the scope is needed to put 'global' fo
Isn't the docstring enough? Could you suggest a specific comment?
Line 571: _execCmd(command)
Line 572:
Line 573:
Line 574: def linkAdd(name, linkType, link=None, args=()):
--
To view, visit http://gerrit.ovirt.org/31104
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5708c4db6f6d450536bd243a0475164b89f46f93
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list