Change in vdsm[master]: vm: return diskMapping on status()

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Wed Aug 27 08:02:54 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: vm: return diskMapping on status()
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/31700/5/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 3576: # @displayPort:           The port in use for unencrypted display data
Line 3577: #
Line 3578: # @guestIPs:              A space separated string of assigned IPv4 addresses
Line 3579: #
Line 3580: # @guestDiskMapping:      A dictionary containing information about the disk mapping
> short lines look much better on side-by-side review.
IIUC the patch, it will always return at least an empty dict.
(which is useless indeed, but not really wrong)
Maybe we really should do a little bit more processing in vdsm and make the serial number part of disk information instead.
Line 3581: #                         within the guest. The key is the device serial and the value is
Line 3582: #                         the mapping information.
Line 3583: #
Line 3584: # @smartcardEnable:       Info whether smartcard is enabled.


-- 
To view, visit http://gerrit.ovirt.org/31700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list