Change in vdsm[master]: vm: return diskMapping on status()

laravot at redhat.com laravot at redhat.com
Wed Aug 27 07:36:26 UTC 2014


Liron Aravot has posted comments on this change.

Change subject: vm: return diskMapping on status()
......................................................................


Patch Set 5:

(1 comment)

@Nir - see the comment to Dan here. http://gerrit.ovirt.org/#/c/31700/5//COMMIT_MSG .

http://gerrit.ovirt.org/#/c/31700/5//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vm: return diskMapping on status()
Line 8: 
Line 9: status() is used by API.Global.getVMList and should return also the disk
Line 10: mapping retrieved by the guest agent.
> I'm surprised to see new stuff added to the list() verb. It should report o
Sure, i'll add it.

list(Full=true) is called by the engine when the returned hash in getAllVmStats changes (as oppsed to list(Full=false). you can see in the following patch http://gerrit.ovirt.org/#/c/31701/ that the disk mapping was added to that hash calculation to avoid return it each call to getAllVmStats as it will rarely change (when you hotplug for example).
The question whether to add it to list(Full=True) or in a separate verb for guest stats only is an interesting question, before implementing it it was discussed with virt guys (Michal,Vinzenz and later on Francesco) and it was decided to add it there.
Line 11: 
Line 12: Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49


-- 
To view, visit http://gerrit.ovirt.org/31700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list