Change in vdsm[master]: oop: change log level

mtayer at redhat.com mtayer at redhat.com
Wed Aug 27 07:33:52 UTC 2014


mooli tayer has posted comments on this change.

Change subject: oop: change log level
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/31908/1/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:

Line 216:     def rename(self, oldpath, newpath):
Line 217:         '''
Line 218:         WARNING: Renaming a directory is not an atomic op.
Line 219:         Supported in the same manner as Python's os.rename.
Line 220:         '''
1.) I think this in a proper log and not syslog is a lot better.

2.) Someone that understands this message better than me can
 consider making this debug/trace.
 I do agree that if a developer did not read a function's documentation
 he isn't any more likely to see a log message
Line 221:         log.warning("renaming a directory is not an atomic operation")
Line 222:         try:
Line 223:             return self._iop.rename(oldpath, newpath)
Line 224:         except OSError as e:


-- 
To view, visit http://gerrit.ovirt.org/31908
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d0474d1d69e227aa12b8b70022930f66e7387d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list