Change in vdsm[master]: tool: Remove duplicate names

ybronhei at redhat.com ybronhei at redhat.com
Tue Aug 26 19:26:12 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: tool: Remove duplicate names
......................................................................


Patch Set 4: Code-Review+1

not better to call it with something more specific to the module, such as libvirtConfigurator, sanlockConfigurator? i dont really mind, but think it'll be more readable. although this change is necessary and the separation to module requires that naming change. acked it, but still think its better to have specific name for each module

-- 
To view, visit http://gerrit.ovirt.org/31775
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list