Change in vdsm[master]: oop: change log level

nsoffer at redhat.com nsoffer at redhat.com
Tue Aug 26 14:59:31 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: oop: change log level
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/31908/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-08-25 15:42:57 +0300
Line 4: Commit:     Yeela Kaplan <ykaplan at redhat.com>
Line 5: CommitDate: 2014-08-25 15:44:02 +0300
Line 6: 
Line 7: oop: change log level
The patch looks fine, but the title is misleading.

I think that this commit message will make it easier to understand the change later:

    oop: Use Storage.oop logger

    Use storage logger to avoid oop logs in /var/log/messages.
    Storage logger is configured to not send messages to syslog.
Line 8: 
Line 9: to avoid oop logs in /var/log/messages
Line 10: 
Line 11: Change-Id: Id2d0474d1d69e227aa12b8b70022930f66e7387d


-- 
To view, visit http://gerrit.ovirt.org/31908
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d0474d1d69e227aa12b8b70022930f66e7387d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list