Change in vdsm[master]: Live Merge: Mark active layer ILLEGAL before pivoting

alitke at redhat.com alitke at redhat.com
Tue Aug 26 14:20:45 UTC 2014


Adam Litke has posted comments on this change.

Change subject: Live Merge: Mark active layer ILLEGAL before pivoting
......................................................................


Patch Set 2: -Verified

(1 comment)

http://gerrit.ovirt.org/#/c/31787/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1853:             subChainTailVol = sdDom.produceVolume(imgUUID, subChain[-1])
Line 1854:             children = subChainTailVol.getChildren()
Line 1855:             for childID in children:
Line 1856:                 sdDom.produceVolume(imgUUID, childID).setParentMeta(dstParent)
Line 1857:             if not children:
> With the current code it's hard to understand that "for" and "if not childr
you're right.  Updating.
Line 1858:                 self.log.debug("Leaf volume is being removed from the chain. "
Line 1859:                                "Marking it ILLEGAL to prevent data corruption")
Line 1860:                 subChainTailVol.setLegality(volume.ILLEGAL_VOL)
Line 1861: 


-- 
To view, visit http://gerrit.ovirt.org/31787
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97ce8fbdfad7c81181a206f160ffdd647c552d4d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list