Change in vdsm[master]: tool: Fix TypeError when configuration check fails

danken at redhat.com danken at redhat.com
Mon Aug 25 11:27:43 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tool: Fix TypeError when configuration check fails
......................................................................


tool: Fix TypeError when configuration check fails

When is-configured and validate-config failed for some modules, we got a
TypeError trying to join a list of configurator objects, instead of list
of strings.

    TypeError: sequence item 0: expected string, Sanlock found

Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31782
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: mooli tayer <mtayer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  mooli tayer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/31782
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list