Change in vdsm[master]: signals: Handle signals to non-main threads

nsoffer at redhat.com nsoffer at redhat.com
Sun Aug 24 11:48:13 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: signals: Handle signals to non-main threads
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/29392/10/lib/vdsm/sigutils.py
File lib/vdsm/sigutils.py:

Line 95:         if e[0] == errno.EINTR:
Line 96:             # We need to clean up the pipe
Line 97:             _empty_pipe(_signal_read_fd)
Line 98:         else:
Line 99:             logging.exception('Received error while waiting for signal')
The check for events should be here:

    try:
        events = ...
    except ...
        handle error
    else:
        if events:
            ...
Line 100: 
Line 101: 
Line 102: def _empty_pipe(fd):
Line 103:     while True:


-- 
To view, visit http://gerrit.ovirt.org/29392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list