Change in vdsm[master]: tool: Create configurators once

nsoffer at redhat.com nsoffer at redhat.com
Sun Aug 24 10:18:58 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tool: Create configurators once
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/31739/3/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 36: _CONFIGURATORS = dict((m.getName(), m) for m in (
Line 37:     certificates.Certificates(),
Line 38:     libvirt.Libvirt(),
Line 39:     sanlock.Sanlock(),
Line 40: ))
> this should be a separate patch
What is "this"?
Line 41: 
Line 42: 
Line 43: @expose("configure")
Line 44: def configure(*args):


-- 
To view, visit http://gerrit.ovirt.org/31739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0e258dc28557661bf85734f000e43f20b1e512
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: jian wang <wjian84 at gmail.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list