Change in vdsm[master]: tool: Make configurators more Pythonic

ybronhei at redhat.com ybronhei at redhat.com
Thu Aug 21 18:03:17 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: tool: Make configurators more Pythonic
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

re trigger the jenkins job please

http://gerrit.ovirt.org/#/c/31741/4/tests/toolTests.py
File tests/toolTests.py:

Line 77:         lambda:  {
Line 78:             'a': MockModuleConfigurator('a', {'b', 'd'}),
Line 79:             'b': MockModuleConfigurator('b', {'c'}),
Line 80:             'c': MockModuleConfigurator('c', {'e', 'd'}),
Line 81:             'd': MockModuleConfigurator('d', {'e', 'e'}),
so you can do - ('a', set(['c', 'b'])) if you want to keep the same behavior without the SyntaxError in python 2.6

fix it in sepatate patch
Line 82:             'e': MockModuleConfigurator('e', set()),
Line 83:             'f': MockModuleConfigurator('f', set()),
Line 84: 
Line 85:         }


-- 
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16092da09d6763a8222bc941bd7d1501a7bb3bff
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list