Change in vdsm[master]: tool: Fix TypeError when configuration check fails

nsoffer at redhat.com nsoffer at redhat.com
Thu Aug 21 16:40:14 UTC 2014


Nir Soffer has uploaded a new change for review.

Change subject: tool: Fix TypeError when configuration check fails
......................................................................

tool: Fix TypeError when configuration check fails

When is-configured and validate-config failed for some modules, we got a
TypeError trying to join a list of configurator objects, instead of list
of strings.

    TypeError: sequence item 0: expected string, Sanlock found

Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/31782/1

diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 268ae46..438cef0 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -97,7 +97,8 @@
     ret = True
     args = _parse_args(*args)
 
-    m = [c for c in args.modules if c.isconfigured() == NOT_CONFIGURED]
+    m = [c.getName() for c in args.modules
+         if c.isconfigured() == NOT_CONFIGURED]
 
     if m:
         sys.stdout.write(
@@ -131,7 +132,7 @@
     ret = True
     args = _parse_args(*args)
 
-    m = [c for c in args.modules if not c.validate()]
+    m = [c.getName() for c in args.modules if not c.validate()]
 
     if m:
         sys.stdout.write(


-- 
To view, visit http://gerrit.ovirt.org/31782
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list