Change in vdsm[master]: Live Merge: Extend internal block volumes during merge

nsoffer at redhat.com nsoffer at redhat.com
Thu Aug 21 15:16:06 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Live Merge: Extend internal block volumes during merge
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/31268/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2126:                 drive = self._findDriveByUUIDs(job['disk'])
Line 2127:             except LookupError:
Line 2128:                 # After an active layer merge completes the vdsm metadata will
Line 2129:                 # be out of sync for a brief period.  If we cannot find the old
Line 2130:                 # disk then it's safe to skip it.
Lets add a debug log, so we don't miss a real missing drive. Since this should happen only for one drive and only for short period of time, this will not create too much noise in the log.

Or even better, hide the error *only* if this is the disk where the active layer is merged.
Line 2131:                 continue
Line 2132:             if not drive.blockDev or drive.format != 'cow':
Line 2133:                 continue
Line 2134: 


-- 
To view, visit http://gerrit.ovirt.org/31268
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a9e0ebdb9c42df713c40e0fc5782945eb7228a8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list