Change in vdsm[master]: tool: Make configurators more Pythonic
Alon Bar-Lev
alonbl at redhat.com
Thu Aug 21 14:48:27 UTC 2014
Alon Bar-Lev has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py
File lib/vdsm/tool/configurators/__init__.py:
Line 55: # Services that must not run when this module is configured. The specified
Line 56: # services will be stopped before this configurator is called, and will be
Line 57: # started in reversed order when the configurator is done.
Line 58: # May be overriden by subclass.
Line 59: services = ()
please use either functions or attributes, having variables is something that should be avoided as these can change without notice.
Line 60:
Line 61: def validate(self):
Line 62: return True
Line 63:
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16092da09d6763a8222bc941bd7d1501a7bb3bff
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list