Change in vdsm[master]: tool: Remove pointless __init__ methods

Alon Bar-Lev alonbl at redhat.com
Thu Aug 21 14:47:16 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: tool: Remove pointless __init__ methods
......................................................................


Patch Set 2:

the reason for keeping these is that one day one might add some initialization at base, and at that day all classes will have to be modified.

this is part of the invalid python design and is addressed by "pointless" code.

this is part of vdsm so do whatever vdsm conventions are, but it does has a value in other plains of existence :)

-- 
To view, visit http://gerrit.ovirt.org/31740
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list