Change in vdsm[master]: Live Merge: Update path using libvirt supplied value

fromani at redhat.com fromani at redhat.com
Thu Aug 21 14:14:49 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: Live Merge: Update path using libvirt supplied value
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/31365/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 5529:             if not sourceXML:
Line 5530:                 break
Line 5531:             sourceAttr = ('file', 'dev')[drive.blockDev]
Line 5532:             path = sourceXML.getAttribute(sourceAttr)
Line 5533:             entry = VolumeChainEntry(pathToVolID(drive, path), path)
> Sure.  It seems that fromani was encouraging me to cut down on intermediate
I have zero problems with intermediatess if they make the code looks nicer, so no objections here.
Line 5534:             volChain.insert(0, entry)
Line 5535:             bsXML = findElement(diskXML, 'backingStore')
Line 5536:             if not bsXML:
Line 5537:                 break


-- 
To view, visit http://gerrit.ovirt.org/31365
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie341333ad934645c0fe4f2fd31733c459d306d9a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list