Change in vdsm[master]: Live Merge: Return more info from _driveGetActualVolumeChain

alitke at redhat.com alitke at redhat.com
Thu Aug 21 13:30:38 UTC 2014


Adam Litke has posted comments on this change.

Change subject: Live Merge: Return more info from _driveGetActualVolumeChain
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/31364/4//COMMIT_MSG
Commit Message:

Line 9: In followup patches, we want to return more information about each path
Line 10: component from _driveGetActualVolumeChain.  We need the actual path as
Line 11: given in the domain XML in order to properly update our metadata after
Line 12: an active layer merge.  We also want to use this function to return high
Line 13: write watermark information for block volumes.  This patch just converts
> Why not add a way to start/stop monitoring a drive, so we can start monitor
That is another way to do it.  I chose this approach because it seemed like an easier way to batch calls together in order to reduce calls to libvirt.  I am open to optimizing performance of this code in the future and have already discussed some ideas with @fromani.  Your suggestion would probably be an improvement once we have a centralized monitor that routinely fetches the domain XML and fires a list of handlers each time the xml is updated.  We don't have that yet though.
Line 14: the format returned by _driveGetActualVolumeChain from a simple list to
Line 15: a list of named tuples.
Line 16: 
Line 17: Change-Id: I01d142a68903048accc95eb04d9930c326965db0


-- 
To view, visit http://gerrit.ovirt.org/31364
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01d142a68903048accc95eb04d9930c326965db0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list