Change in vdsm[master]: vm, guestagent: return hash should include also the disk map...

fromani at redhat.com fromani at redhat.com
Thu Aug 21 12:58:20 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm, guestagent: return hash should include also the disk mapping
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/31701/3/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 304:                 disks.append(disk)
Line 305:             self.guestInfo['disksUsage'] = disks
Line 306:             self.guestDiskMapping = args.get('mapping', {})
Line 307:             self.diskMappingHash = hash(json.dumps(self.guestDiskMapping,
Line 308:                                                     sort_keys=True))
> more elaboration -
Good enough reason for me.
Line 309:         elif message == 'number-of-cpus':
Line 310:             self.guestInfo['guestCPUCount'] = int(args['count'])
Line 311:         else:
Line 312:             self.log.error('Unknown message type %s', message)


-- 
To view, visit http://gerrit.ovirt.org/31701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I148196ccf353613f9cffed7753e7100bd1dd30de
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list