Change in vdsm[master]: vm: return diskMapping on status()

amureini at redhat.com amureini at redhat.com
Thu Aug 21 10:24:17 UTC 2014


Allon Mureinik has posted comments on this change.

Change subject: vm: return diskMapping on status()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/31700/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2435:         self.conf['status'] = self.lastStatus
Line 2436:         # Filter out any internal keys
Line 2437:         d = dict((k, v) for k, v in self.conf.iteritems()
Line 2438:                     if not k.startswith("_"))
Line 2439:         d['diskMapping'] = self.guestAgent.guestDiskMapping
> I don't think it's a problem.
I agree with Vinzenz - let's not overthink this.
Line 2440:         return d
Line 2441: 
Line 2442:     def getStats(self):
Line 2443:         """


-- 
To view, visit http://gerrit.ovirt.org/31700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list