Change in vdsm[master]: gluster: geo replication status and status detail

sabose at redhat.com sabose at redhat.com
Thu Aug 21 10:19:25 UTC 2014


Sahina Bose has posted comments on this change.

Change subject: gluster: geo replication status and status detail
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/18414/6/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1149:     }
Line 1150:     """
Line 1151:     status = {}
Line 1152:     status['volumeName'] = tree.find('geoRep/volume/name').text
Line 1153:     status['sessionSalve'] = tree.find(
sessionSlave?
Line 1154:         'geoRep/volume/sessions/session/session_slave').text
Line 1155:     pairs = []
Line 1156:     for pair in tree.findall('geoRep/volume/sessions/session/pair'):
Line 1157:         pairDetail = {}


Line 1150:     """
Line 1151:     status = {}
Line 1152:     status['volumeName'] = tree.find('geoRep/volume/name').text
Line 1153:     status['sessionSalve'] = tree.find(
Line 1154:         'geoRep/volume/sessions/session/session_slave').text
Shouldn't you iterate through all sessions as well?
A volume could have multiple sessions
Line 1155:     pairs = []
Line 1156:     for pair in tree.findall('geoRep/volume/sessions/session/pair'):
Line 1157:         pairDetail = {}
Line 1158:         pairDetail['masterNode'] = pair.find('master_node').text


-- 
To view, visit http://gerrit.ovirt.org/18414
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f37f35a5480fbe049a67758e122d4a0c2eba513
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi at gmail.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list