Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

nsoffer at redhat.com nsoffer at redhat.com
Wed Aug 20 22:37:16 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Move multipath configuration to vdsm-tool configurator
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/30909/6/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 745:             utils.rotateFiles(
Line 746:                 os.path.dirname(self._MPATH_CONF),
Line 747:                 os.path.basename(self._MPATH_CONF),
Line 748:                 self._MAX_CONF_COPIES,
Line 749:                 cp=True, persist=True)
I think this shold be rebased on I think you should rebase this on http://gerrit.ovirt.org/31583.

Otherwise I don't see how do you have utils.rotateFiles here - it was moved by that patch from misc to utils.
Line 750:         with tempfile.NamedTemporaryFile() as f:
Line 751:             f.write(self._MPATH_CONF_TEMPLATE %
Line 752:                     {'scsi_id_path': self._scsi_id.cmd})
Line 753:             f.flush()


Line 777:         If the tag above is followed by tag "RHEV PRIVATE" the configuration
Line 778:         should be preserved at all cost.
Line 779:         """
Line 780:         if os.getuid() != 0:
Line 781:             raise NotRootError()
This may be unneeded because of http://gerrit.ovirt.org/31293

Lets wait until that one is merged.
Line 782: 
Line 783:         if os.path.exists(self._MPATH_CONF):
Line 784:             first = second = ''
Line 785:             with open(self._MPATH_CONF) as f:


-- 
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list