Change in vdsm[master]: vm: remove guest agent channels tunables

danken at redhat.com danken at redhat.com
Wed Aug 20 21:21:38 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: remove guest agent channels tunables
......................................................................


vm: remove guest agent channels tunables

We had tunables to disable vm/ga channels creation from a long time,
but it was just on debug purposes and these settings should never
be used in production.

Moreover, we acttually rely on the channel being here (see
RHBZ#1126887).

Since it is now possible the achive the same results through hooks,
it is time to drop these tunables.

Change-Id: I4774441d7bd6dcdbb58e38886eb522851d4af37c
Relates-To: https://bugzilla.redhat.com/1126887
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31245
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M client/vdsClient.py
M tests/vmTestsData.py
M vdsm/virt/vm.py
3 files changed, 9 insertions(+), 22 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/31245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4774441d7bd6dcdbb58e38886eb522851d4af37c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Cao Bing <caobingbu at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list