Change in vdsm[master]: vm, guestagent: hash to include also the disk mapping

nsoffer at redhat.com nsoffer at redhat.com
Wed Aug 20 16:59:26 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vm, guestagent: hash to include also the disk mapping
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/31701/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4514:     def _getUnderlyingVmInfo(self):
Line 4515:         self._lastXMLDesc = self._dom.XMLDesc(0)
Line 4516:         devxml = _domParseStr(self._lastXMLDesc).childNodes[0]. \
Line 4517:             getElementsByTagName('devices')[0]
Line 4518:         self._devXmlHash = hash(devxml.toxml())
> basically the idea behind it is that there's no need to convert it to strin
This change is not required for the purpose of this patch - consider both xml and disk mapping in the hash.
Line 4519: 
Line 4520:         return self._lastXMLDesc
Line 4521: 
Line 4522:     def _ejectFloppy(self):


-- 
To view, visit http://gerrit.ovirt.org/31701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I148196ccf353613f9cffed7753e7100bd1dd30de
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list