Change in vdsm[master]: networkTests: UNKNOWN operstate
danken at redhat.com
danken at redhat.com
Wed Aug 20 09:48:35 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: networkTests: UNKNOWN operstate
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/30787/7/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 165: def _alarmHandler(signum, frame):
Line 166: raise Alarm
Line 167:
Line 168: monitor = ipwrapper.Monitor()
Line 169: monitor.start()
Please add "try" here, and call monitor.stop() on "finally". Otherwise, we leak a process.
Line 170: state = operstate(device).upper()
Line 171: if state == 'UNKNOWN':
Line 172: signal.signal(signal.SIGALRM, _alarmHandler)
Line 173: signal.alarm(timeout)
--
To view, visit http://gerrit.ovirt.org/30787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a5a059e717a331ae5e01cb64b7badc6757d4257
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list