Change in vdsm[master]: Handle and store serial to guest device names mapping

laravot at redhat.com laravot at redhat.com
Tue Aug 19 23:14:35 UTC 2014


Liron Aravot has posted comments on this change.

Change subject: Handle and store serial to guest device names mapping
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/31497/3/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 304:             self.guestDiskMapping = {}
Line 305:             if 'mapping' in args:
Line 306:                 for disk in args['mapping']:
Line 307:                     self.guestDiskMapping[disk['serial']] = {'name':
Line 308:                                                              disk['name']}
don't we need to first create the object and only when it's done change self.guestDiskMapping to point to it? otherwise we might encounter concurrency issues (add items here while attempting to iterate over it from the outside).
Line 309:         elif message == 'number-of-cpus':
Line 310:             self.guestInfo['guestCPUCount'] = int(args['count'])
Line 311:         else:
Line 312:             self.log.error('Unknown message type %s', message)


-- 
To view, visit http://gerrit.ovirt.org/31497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69db18414b17b23eb7bcbfbd8b2584f622e53276
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list