Change in vdsm[master]: networkTests: assertBondDoesntExist with nics=None

danken at redhat.com danken at redhat.com
Tue Aug 19 15:00:55 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: networkTests: assertBondDoesntExist with nics=None
......................................................................


networkTests: assertBondDoesntExist with nics=None

When assertBondDoesntExist is used with nics=None, it raises an
error "'NoneType' object is not iterable".

I changed it to assert nics only when defined.

Change-Id: I43da6b2b6d7cfb79a64c37600477a69831acbf94
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31334
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/31334
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43da6b2b6d7cfb79a64c37600477a69831acbf94
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list