Change in vdsm[master]: api, iproute2, dhclient: Support DHCPv6
osvoboda at redhat.com
osvoboda at redhat.com
Tue Aug 19 12:20:10 UTC 2014
Ondřej Svoboda has posted comments on this change.
Change subject: api, iproute2, dhclient: Support DHCPv6
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/30554/8/vdsm/network/configurators/iproute2.py
File vdsm/network/configurators/iproute2.py:
Line 256: dhclient = DhcpClient(iface.name)
Line 257: rc = dhclient.start(iface.ipConfig.async)
Line 258: if not iface.ipConfig.async and rc:
Line 259: raise ConfigNetworkError(ERR_FAILED_IFUP, 'dhclient failed')
Line 260: if iface.ipConfig.dhcpv6:
> This is code duplication. Why not just have the code once and have family a
I will factor out the common code.
Line 261: dhclient = DhcpClient(iface.name, family=6)
Line 262: rc = dhclient.start(iface.ipConfig.async)
Line 263: if not iface.ipConfig.async and rc:
Line 264: raise ConfigNetworkError(ERR_FAILED_IFUP, 'dhclient6 failed')
--
To view, visit http://gerrit.ovirt.org/30554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40a3d5d63d14e6a1cb8a70894a63de3a3367b9e7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: jian wang <wjian84 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list