Change in vdsm[master]: virt: keep on sampling before /var/run/vdsm/client.log exists

fromani at redhat.com fromani at redhat.com
Tue Aug 19 08:33:28 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: keep on sampling before /var/run/vdsm/client.log exists
......................................................................


Patch Set 1: Code-Review+1

Looks good to me.

Suggestion for possible improvements (future patches)
- add test(s). This issue dodged the first review cycle, and it is nasty enough to deserve a test to make sure it will not fade away from our memories.
- factorize this common code somehow, maybe an utils function is enough.

-- 
To view, visit http://gerrit.ovirt.org/31619
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb7d380882f5a93e5c75eda80598f382744b178c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list